projection: Return correct collation information #15801
Merged
+49
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have a project, we correctly convert the value to the connection collation using: ```go c.Value(vcursor.ConnCollation()) ``` But we then don't update / change the collation on the fields information. This needs to match the actual data, otherwise the client might corrupt the data. This ensures we add the same rules for the resulting collation. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
requested review from
harshit-gangal,
systay,
frouioui and
GuptaManan100
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
dbussink
added
Type: Bug
Component: Evalengine
|
Marked this for back porting, since this can lead to the clients corrupting data / interpreting it as wrongly encoded information and could unexpectedly error out. |
vmg
approved these changes
Apr 26, 2024
systay
approved these changes
Apr 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15801 +/- ##
==========================================
- Coverage 68.42% 68.42% -0.01%
==========================================
Files 1558 1558
Lines 196036 196039 +3
==========================================
+ Hits 134136 134137 +1
- Misses 61900 61902 +2 ☔ View full report in Codecov by Sentry. |
This was referenced Apr 26, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Apr 26, 2024
Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
added a commit
that referenced
this pull request
Apr 27, 2024
…) (#15804) Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Dirkjan Bussink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a project, we correctly convert the value to the connection collation using:
But we then don't update / change the collation on the fields information. This needs to match the actual data, otherwise the client might corrupt the data.
This ensures we add the same rules for the resulting collation.
Related Issue(s)
Fixes #15800
Checklist